Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/22#discussion_r15700722
--- Diff: app/core/layout.js ---
@@ -10,82 +10,31 @@
// License for the specific language governing permissions and limitations
under
// the License.
-define([
- "backbone",
- "plugins/backbone.layoutmanager"
-], function(Backbone) {
+define(function(require, exports, module) {
--- End diff --
We haven't used the commonjs convention. So since we use the `define` with
library names there its better we stick to that one convention.
I'm happy to do a change to the commonjs approach but in a seperate patch
and we would have to do it to all modules.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
