[
https://issues.apache.org/jira/browse/COUCHDB-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178465#comment-14178465
]
ASF GitHub Bot commented on COUCHDB-2357:
-----------------------------------------
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/86#issuecomment-59938294
> Should I rebase the commits into a single one?
That would be awesome! Please squash the commit and create a commit message
that describes the fix and references the jira issue. The commit message should
have 72 chars per line.
Example:
```
Fix disappearing logout link
Also add header link when user is already logged in and is reloading
the browser which does not change the session
Closes COUCHDB-2357
```
This way the Jira ticket gets updated when we merge the commit. The reason
for 72 chars is the default terminal size that most people have. We probably
should document this somewhere.
The patch looks nice, but there are some added whitespaces which don't not
belong there, I commented the places for you. If you are rebasing anyway, you
can just remove them.
> Logout link disappears from sidebar on browser reload
> -----------------------------------------------------
>
> Key: COUCHDB-2357
> URL: https://issues.apache.org/jira/browse/COUCHDB-2357
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Fauxton
> Reporter: Javier Candeira
>
> The Logout link disappears from the Fauxton sidebar on reloading the current
> URL in the browser.
> It reappears if the user logs out manually (by adding the edited fragment
> `#logout` by hand on the address bar and hitting <Enter>) and logs in again.
> This has been observed in the following branches:
> master
> sidebar-fixes
> Update-Sidebar
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
