Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/207#discussion_r22032059
--- Diff: app/addons/documents/shared-resources.js ---
@@ -0,0 +1,317 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+define([
+ 'app',
+ 'api',
+ 'cloudant.pagingcollection'
+], function (app, FauxtonAPI, PagingCollection) {
+
+ var Documents = FauxtonAPI.addon();
--- End diff --
I don't think we should be defining the Documents addon in the shared
Resources file. I think define it in either base.js or resources.js and the
shared resources can get merged onto that object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
