Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/204#discussion_r22266411
  
    --- Diff: app/addons/documents/routes-doc-editor.js ---
    @@ -24,10 +22,26 @@ define([
     
     function(app, FauxtonAPI, Documents, DocEditor, Databases) {
     
    +
    +  // helper
    +  function getPreviousPage (database) {
    --- End diff --
    
    It doesn't belong here, I agree. But it's not really general enough for 
most pages: the extra code in it that checks that it doesn't come from `/new` 
is specific to this particular page. I think I'll stick it in the document 
addon's resources file. I almost want to introduce a new addon-specific 
helpers.js file for this sort of thing (i.e. non-model/collection-related, but 
plain ol' helper functions).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to