Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/258#discussion_r24683640
  
    --- Diff: app/addons/documents/resources.js ---
    @@ -216,11 +214,18 @@ function(app, FauxtonAPI, Documents, 
PagingCollection) {
           } else if (context === "apiurl"){
             startOfUrl = window.location.origin;
           }
    -      var design = app.utils.safeURLName(this.design),
    -          view = app.utils.safeURLName(this.view);
     
    -      var url = [startOfUrl, this.database.safeID(), "_design", design, 
this.idxType, view];
    -      return url.join("/") + query;
    +      var database = this.database.safeID(),
    +          design = app.utils.safeURLName(this.design),
    +          view = app.utils.safeURLName(this.view),
    +          url = FauxtonAPI.urls('view', 'server', database, design, view);
    +
    +      if (url === '') {
    --- End diff --
    
    I'd definitely look into this chunk. Does seem a bit fishy that url *may* 
be empty. Is that possible, with the new FauxtonAPI.urls method? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to