Github user patrickstuedi commented on a diff in the pull request:
https://github.com/apache/incubator-crail/pull/26#discussion_r196787934
--- Diff: bin/crail ---
@@ -70,4 +70,4 @@ fi
export CLASSPATH="$bin"/../jars/*:"$bin"/../conf:.
export LD_LIBRARY_PATH="$bin/../lib:$LD_LIBRARY_PATH"
-exec "$JAVA" -Dproc_$COMMAND -XX:MaxDirectMemorySize=64G
-Dsun.nio.PageAlignDirectMemory=true -Xmn16G $CLASS "$@"
+exec "$JAVA" -Dproc_$COMMAND -Dsun.nio.PageAlignDirectMemory=true $CLASS
"$@"
--- End diff --
Can we safely remove those parameters? What about MaxDirectMemorySize, do
we need this to support large memory configurations? What about Xmn16G, is
removing this not creating a performance problem for large memory
configurations?
---
