PepperJo commented on a change in pull request #73: change the implement of
$JAVA
URL: https://github.com/apache/incubator-crail/pull/73#discussion_r266369211
##########
File path: bin/crail
##########
@@ -78,4 +77,4 @@ if [ -f "${CONF_PATH}/crail-env.sh" ]; then
set +a
fi
-exec "$JAVA" -Dproc_$COMMAND -Dsun.nio.PageAlignDirectMemory=true
$CRAIL_EXTRA_JAVA_OPTIONS $CLASS "$@"
+exec "java" -Dproc_$COMMAND -Dsun.nio.PageAlignDirectMemory=true
$CRAIL_EXTRA_JAVA_OPTIONS $CLASS "$@"
Review comment:
We want the user to be able to switch between JVMs easily. The JAVA_HOME
environment variable is a pretty common way to do this. However, I understand
that this might be a hassle, so we could introduce a check if JAVA_HOME is set
and if it is not set set JAVA to "java".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
