Hi, since I don't have any clue about CDLL could anyone evaluate whether this fix should/could be applied?
Do we need more testcases? Am 11.09.2014 um 16:24 schrieb Chris Burroughs (JIRA): > [ > https://issues.apache.org/jira/browse/RAT-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Chris Burroughs updated RAT-174: > -------------------------------- > Attachment: r174.v1.patch > > Replace expensive regex patterns with simple text checks > > With this change `apache-rat:rat` is approxiatly the same speed with and > without CDDL1License checks enabled instead of being an order of magnitude > slower. > > Note: When developing I noticed that Illumos (the most prominent CDDL project > I am aware of) uses a slightly different string than what was in the unit > tests. The unit tests all pass, but this is a behavior change. For example > some unrelated text and a mention of `https://oss.oracle.com/licenses/CDDL` > would no longer match. I don't have enough familiarty with CDDL users to > know if even wider variation is common. Thanks, Phil
signature.asc
Description: OpenPGP digital signature
