[ 
https://issues.apache.org/jira/browse/RAT-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323338#comment-14323338
 ] 

Dan Dumont edited comment on RAT-190 at 2/16/15 9:40 PM:
---------------------------------------------------------

But there's no valid license in the file, and when RAT scans it, it's passed if 
the encodings are different.
Even a warning here doesn't make sense to me...   the plugin is supposed to 
audit my release, if it can't scan a file it should fail on it because it can't 
do the audit.


was (Author: ddumont):
Well.   The warnings are great.

But there's no valid license in the file, and when RAT scans it, it's passed if 
the encodings are different.
Even a warning here doesn't make sense to me...   the plugin is supposed to 
audit my release, if it can't scan a file it should fail on it because it can't 
do the audit.

> False negatives(?) in apache rat license checking
> -------------------------------------------------
>
>                 Key: RAT-190
>                 URL: https://issues.apache.org/jira/browse/RAT-190
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.8, 0.11
>            Reporter: Dan Dumont
>            Assignee: Philipp Ottlinger
>         Attachments: complete-pom.xml, test.zip
>
>
> We're using rat to enforce our internal copyright on all of our source files.
> We're seeing it missing files that should be flagged.  Here's part of our pom:
> <licenses>
>   <license 
> implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
>     <licenseFamilyCategory>IBMCL</licenseFamilyCategory>
>     <licenseFamilyName>IBM Copyright</licenseFamilyName>
>     <notes></notes>
>     <patterns>
>       <pattern>Copyright IBM Corp. 2015</pattern>
>       <pattern>Copyright IBM Corp. 2014, 2015</pattern>
>       <pattern>Copyright IBM Corp. 2013, 2015</pattern>
>     </patterns>
>   </license>
> </licenses>
> <licenseFamilies>
>   <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
>   <familyName>IBM Copyright</familyName>
> </licenseFamily>
> </licenseFamilies>
> The file in question is "included" as reported by running with debug 
> output...  but the file's copyright is:
> /* Copyright IBM Corp. 2014  All Rights Reserved.                    */



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to