jbonofre commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377217935
########## apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java: ########## Review Comment: I'm not sure: I think it's already covered by the excludes. If we are able to read *all* directories (including the hidden files), then we can filter with exclude. I think introducing a filter for "include" would be confusing. I would rather read all directories and delegate to exclude. A valid proposal would be to scan all directories by default (including hidden ones) and use excludes. Thoughts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
