nielsbasjes commented on PR #167: URL: https://github.com/apache/creadur-rat/pull/167#issuecomment-1826271391
My main reason for the way I have done it is indeed the fact that the relatively simple "Find the first matching expression" is simply incorrect when it comes to the .gitignore rules. I would not be surprised if something similar is true for other ignore file formats/rulesets. Moving what I have towards something like FileFilters should be quite easy as the code I'm using already has a very similar interface. At this point I'm totally fine with either: - Wait with this until the design discussion is done and then I resubmit this in a new form. - Merge this (after me having updated it with any additional feedback) and then these changes can be included as part of the whole refactoring (which means the newly provided tests can be used). And yes, I would like to contribute where possible. In general what I see as a pattern in the rules: - The default glob rules simply match on a single expression or don't. - The gitignore rules can have rules that override other rules in a single file. - You can have multiple gitignore files in different places in a single project which only affect that area. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
