ottlinger commented on code in PR #166:
URL: https://github.com/apache/creadur-rat/pull/166#discussion_r1405263852
##########
apache-rat-core/src/test/java/org/apache/rat/ReportConfigurationTest.java:
##########
@@ -189,6 +194,19 @@ public void inputFileFilterTest() {
assertEquals(filter, underTest.getInputFileFilter());
}
+ @Test
+ public void directoryFilterTest() {
+ assertNotNull("Directory filter should not be null by default",
underTest.getDirectoryFilter());
+ assertTrue("Directory filter should be a NameBasedHiddenFileFilter one
by default", underTest.getDirectoryFilter() instanceof
NameBasedHiddenFileFilter);
Review Comment:
When I read this I thought of adding assertj and use its
isExactlyInstanceOf(Foo.class) ... not sure if there are reasons to not add
assertj-core ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
