cstamas commented on code in PR #175: URL: https://github.com/apache/creadur-rat/pull/175#discussion_r1421078415
########## pom.xml: ########## @@ -52,12 +52,13 @@ agnostic home for software distribution comprehension and audit tools. <maven.compiler.source>${javaVersion}</maven.compiler.source> <maven.compiler.target>${javaVersion}</maven.compiler.target> <!-- This is the version of Maven required to use the Rat Maven Plugin --> - <mavenVersion>3.2.5</mavenVersion> + <mavenMinVersion>3.2.5</mavenMinVersion> + <mavenVersion>3.9.6</mavenVersion> Review Comment: The point of this update: "we" (Maven project) do it wrong as well, the proper way is to compile against latest (3.9.6) but allow runtime 3.2.5 (min maven). The reason to do so is to pick up deprecations and get notified what is changing, but source and binary compatibility guarantees it to run on min version as well. If you compile against 3.2.5 forever, you get totally disconnected about latest changes and deprecations in Maven APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org