Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1554886994
########## apache-rat-core/src/main/java/org/apache/rat/report/ConfigurationReport.java: ########## @@ -0,0 +1,285 @@ +/* Review Comment: The functionality in this class should be in an XMLConfigurationWriter that this class will use to deserialize the configuration. ########## apache-rat-core/src/main/java/org/apache/rat/config/parameters/Component.java: ########## @@ -0,0 +1,48 @@ +package org.apache.rat.config.parameters; +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Interface that marks a configuration component like a License or Matcher. + * + */ +public interface Component { + /** Types of components */ + public enum Type { + /** A License, the top level component. May not be used as a child of any component type. */ + License, + /** A Matcher */ + Matcher, + /** A Parameter for example the "id" parameter found in every component */ + Parameter, + /** A parameter without a name. Generally this is a value for the item. For example the enclosed matchers in the "or" license. */ + Unlabeled, Review Comment: this type mixes presentation with functionality. It should be removed and specific display issues addressed in the format serializers/deserializers ########## apache-rat-core/src/main/java/org/apache/rat/Documentation.java: ########## @@ -0,0 +1,152 @@ +/* Review Comment: This class should be placed in the apache-rat-tools project and documented . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
