Claudenw commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564487716
########## apache-rat-core/src/main/java/org/apache/rat/document/impl/ArchiveEntryDocument.java: ########## @@ -37,44 +36,44 @@ public class ArchiveEntryDocument implements Document { private final MetaData metaData = new MetaData(); - public ArchiveEntryDocument(File file, byte[] contents) throws RatException { + public ArchiveEntryDocument(File file, byte[] contents) { super(); name = DocumentImplUtils.toName(file); this.contents = contents; } + @Override public MetaData getMetaData() { return metaData; } + @Override public String getName() { return name; } + @Override public InputStream inputStream() throws IOException { return new ByteArrayInputStream(contents); } + @Override public boolean isComposite() { return DocumentImplUtils.isZipStream(new ByteArrayInputStream(contents)); Review Comment: Actually, this file has no technical changes and should be reverted. But in answer to your question yes, and it is an area I will be looking into shortly. I want us to use the SPDX license matching code to see if we can match LICENSE files and I want to do that within archive files. I am reverting this file because there is no real change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org