ottlinger commented on code in PR #257:
URL: https://github.com/apache/creadur-rat/pull/257#discussion_r1614862935
##########
apache-rat-core/src/main/java/org/apache/rat/Defaults.java:
##########
@@ -104,30 +127,36 @@ public static Builder builder() {
/**
* Reads the configuration files.
- * @param urls the URLs to read.
+ * @param urls the URIs to read.
*/
- private static LicenseSetFactory readConfigFiles(final Log log, final
Collection<URL> urls) {
+ private static LicenseSetFactory readConfigFiles(final Log log, final
Collection<URI> urls) {
Review Comment:
should we rename the parameter to uris as well in order to make it clearer
how we convert the URIs internally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
