Claudenw commented on code in PR #311:
URL: https://github.com/apache/creadur-rat/pull/311#discussion_r1806474811
##########
apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/NoteGuesser.java:
##########
@@ -45,26 +52,37 @@ public class NoteGuesser {
"THIRD_PARTY_NOTICES", "THIRD_PARTY_NOTICES.TXT",
"COPYRIGHT", "COPYRIGHT.TXT",
"BUILDING", "BUILDING.TXT",
- "BUILD", "BUILT.TXT",//
+ "BUILD", "BUILT.TXT",
Review Comment:
Yes it would. But the NoteGuesser needs to be rethought. It should work
like the license matchers do. For example we want to be able to say that
license X requires a copyright notice. So read the notice files and see if the
copyright is found.
I think we have the components to make this work much better but it is not
part of this PR/ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
