[ 
https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905110#comment-17905110
 ] 

ASF subversion and git services commented on RAT-362:
-----------------------------------------------------

Commit 1924ac55d5baa179921ff9a7b3927abc3812fe81 in creadur-rat's branch 
refs/heads/feature/RAT-397 from Claude Warren
[ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=1924ac55 ]

adjusted testing to account for RAT-335 and RAT-362


> plugin: .gitignore not correctly applied - bugfix in underlying 
> gitignore-reader library
> ----------------------------------------------------------------------------------------
>
>                 Key: RAT-362
>                 URL: https://issues.apache.org/jira/browse/RAT-362
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.16.1
>            Reporter: Arnout Engelen
>            Assignee: Claude Warren
>            Priority: Minor
>             Fix For: 0.17
>
>
> When I have a Maven project checked out in the directory '/foo', and I have a 
> file called 'foo.md' in the root of that project, ignoring it by putting a 
> '/foo.md' entry in the .gitignore file does not work.
> It is unclear whether this is an issue in the plugin or in de codeowners 
> gitignore-reader dependency: the plugin is passing relative filenames (i.e. 
> 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method 
> don't make it too clear whether that is intended to accept absolute 
> filenames, relative filename, or both.
> In this scenario, it seems to take the relative filename 'foo.md' and remove 
> the project base directory '/foo' from it, leaving '/.md' (which then of 
> course does not match the 'foo.md' from the .gitignore).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to