Claudenw commented on PR #422: URL: https://github.com/apache/creadur-rat/pull/422#issuecomment-2585904218
> @Claudenw when I read the description I thought of "FilterEntrySkipper" or "DocumentSkipper/FilterSkipper" ;) Not sure if DocumentExcluder is an easier2understand name. Should the class be renamed as well since DocumentNameMatcher seems rather "abstract" .... if it skips entries in the filtering/scanning process. @ottlinger The DocumentNameMatcher is untouched in this PR. It does what it says. It matches document names. The excluder is a use of the document matcher. That is documents that match it are excluded. When reading the code it begins to make more sense and when debugging it is much easier to remember that if the name matches the excluder it is excluded. I am open to other names but would prefer not to rename the DocumentNameMatcher in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
