ottlinger commented on code in PR #421:
URL: https://github.com/apache/creadur-rat/pull/421#discussion_r1927777173


##########
apache-rat-core/src/main/java/org/apache/rat/api/Document.java:
##########
@@ -61,11 +61,11 @@ public enum Type {
     /**
      * Creates an instance.
      * @param name the native NameSet of the resource.
-     * @param nameExcluder the document name matcher to filter 
directories/files.
+     * @param nameMatcher the document name matcher to filter 
directories/files.
      */
-    protected Document(final DocumentName name, final DocumentNameMatcher 
nameExcluder) {
+    protected Document(final DocumentName name, final DocumentNameMatcher 
nameMatcher) {

Review Comment:
   Didn't you add the excluder name in a different PR?
   Did you change your mind or is it a merge problem? @Claudenw 



##########
apache-rat-core/src/main/java/org/apache/rat/config/exclusion/plexus/MatchPatterns.java:
##########
@@ -41,15 +42,15 @@ private MatchPatterns(final MatchPattern[] patterns) {
 
     @Override
     public String toString() {
-        return source();
+        return 
Arrays.stream(patterns).map(MatchPattern::toString).collect(Collectors.toList()).toString();

Review Comment:
   Should we add a separator between entries to improve readability?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to