ottlinger commented on code in PR #553:
URL: https://github.com/apache/creadur-rat/pull/553#discussion_r2428929837
##########
apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java:
##########
@@ -193,15 +195,28 @@ private SiteRenderingContext
createSiteRenderingContext(final Locale locale) thr
templateProperties.put((String) entry.getKey(), entry.getValue());
}
- SiteRenderingContext context;
try {
- Artifact skinArtifact =
siteTool.getSkinArtifactFromRepository(session.getLocalRepository(),
- remoteRepositories, decorationModel);
+
+ org.apache.maven.doxia.site.Skin siteSkin = siteModel.getSkin();
+ if (siteSkin == null || siteSkin.getGroupId() == null ||
siteSkin.getArtifactId() == null || siteSkin.getVersion() == null) {
Review Comment:
I'd prefer throwing an exception if no proper skin is defined. Hardcoding
skin coordinates is troublesome as we manage dependencies in pom.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
