Niels Basjes created RAT-509:
--------------------------------

             Summary: Gitignore rules are mixed with Rat exclude rules
                 Key: RAT-509
                 URL: https://issues.apache.org/jira/browse/RAT-509
             Project: Apache Rat
          Issue Type: Bug
          Components: Client - maven
    Affects Versions: 0.17
            Reporter: Niels Basjes


Assume the following simplified example:
A pom.xml with the rat plugin and the config
{code:java}
<configuration>
  <consoleOutput>true</consoleOutput>
  <excludes>
    <exclude>**/*.log</exclude>
  </excludes>
</configuration>{code}

A .gitignore with
{code:java}
target
*.log
!demo.log {code}

A demo.log file with any content that is not a valid license (i.e. "Hello 
World")

Now do mvn validate using plugin version 0.16.1 and it all passed, do the same 
with plugin version 0.17 and it fails.

My assesment is that the full set of rules in the .gitignore files are merged 
to a combined list with the license check rules. This is incorrect, these two 
rules sets have a conceptually different meaning and should not be merged.
Although the check "Is this file ignored by version control" should be used, 
the individual rules in there should not be merged.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to