Claudenw commented on code in PR #708:
URL: https://github.com/apache/creadur-rat/pull/708#discussion_r3773668406
##########
apache-rat-core/src/main/java/org/apache/rat/commandline/ArgumentContext.java:
##########
@@ -46,28 +50,51 @@ public final class ArgumentContext {
* Creates a context with the specified configuration.
* @param workingDirectory the directory from which relative file names
will be resolved.
* @param configuration The configuration that is being built.
- * @param commandLine The command line that is building the configuration.
+ * @param opts the Options for the command line.
+ * @param args the arguments for the options.
+ * @throws ParseException if the options can not parse the arguments.
*/
- public ArgumentContext(final File workingDirectory, final
ReportConfiguration configuration, final CommandLine commandLine) {
+ public ArgumentContext(final File workingDirectory, final
ReportConfiguration configuration, final Options opts, final String[] args)
+ throws ParseException {
this.workingDirectory = DocumentName.builder(workingDirectory).build();
- this.commandLine = commandLine;
+ this.commandLine =
OptionCollectionParser.parseCommandLine(clearSelected(opts), args);
this.configuration = configuration;
}
Review Comment:
move instantiation of CommandLine into ArgumentContext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
