[ 
https://issues.apache.org/jira/browse/CRUNCH-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944399#comment-13944399
 ] 

Gabriel Reid commented on CRUNCH-368:
-------------------------------------

Sounds good. I'm not really worried about breaking compatibility with the 
binary format -- I see this as a pretty transient file format, and I believe 
CRUNCH-329 also broke backwards compatibility (and isn't released yet) so I 
think that's a non-issue (or at least not a new issue). 

Any idea on the actual performance improvement of this patch?

> TupleWritable.Comparator
> ------------------------
>
>                 Key: CRUNCH-368
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-368
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.10.0, 0.8.3
>            Reporter: Chao Shi
>            Assignee: Chao Shi
>         Attachments: crunch-368.patch
>
>
> This patch should improve comparison performance on TupleWritables. It saves 
> the deserialization overhead. It is particularly useful when the input tuple 
> are large, e.g. contains long strings.
> Please note that this changes the binary format of TupleWritable. It adds a 
> var-int indicating size of field after each type code. This is a limitation 
> of the writable system. We do not know the size of each field until fully 
> desalinizing it. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to