[
https://issues.apache.org/jira/browse/CRUNCH-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043751#comment-14043751
]
mac champion commented on CRUNCH-414:
-------------------------------------
The offending logic can be found here:
https://github.com/apache/crunch/blob/apache-crunch-0.8.3/crunch-core/src/main/java/org/apache/crunch/io/text/csv/CSVLineReader.java#L190
Does anyone have any suggestions on a good threshold on when to stop here? I
was thinking about merging it with the "if (totalBytesConsumed >
Integer.MAX_VALUE)" line below, which is probably what I intended originally,
but someone pointed out that integer's max value is pretty large. Any other
recommendations/ideas?
> The CSV file source needs to be a little more robust when handling multi-line
> CSV files
> ---------------------------------------------------------------------------------------
>
> Key: CRUNCH-414
> URL: https://issues.apache.org/jira/browse/CRUNCH-414
> Project: Crunch
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.3
> Reporter: mac champion
> Assignee: mac champion
> Priority: Minor
> Labels: csv, csvparser
> Fix For: 0.8.4
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Brandon Inman recently reported an undesriable behavior in the CSV file
> source group of files. Currently, the CSVLineReader, if reading a malformed
> CSV file, can enter a state where it is perpetually waiting for an end-quote
> character. As he put it, "Malformed files are malformed files and should
> probably fail in some regard, but a hang is obviously undesirable."
> Essentially, the CSVLineReader needs to be tweaked in such a way that an
> informative exception is thrown after some threshold is reached, instead of
> basically just hanging.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
