[
https://issues.apache.org/jira/browse/CRUNCH-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063175#comment-14063175
]
Gabriel Reid commented on CRUNCH-400:
-------------------------------------
Patch looks good, with the exception of the class-level javadoc in
MaterializableIterable (it just has the single word "Represents").
One other point that I noticed (although I don't think it's really a problem
with this patch) is that pipeline.run() can return null if there is an error
while running the pipeline. I don't think that should be what happens, but
right now in that case an NPE will be thrown in the new code here. I'll add a
new ticket for not returning null from pipeline.run().
> Materialized jobs should have stage in PipelineResult
> -----------------------------------------------------
>
> Key: CRUNCH-400
> URL: https://issues.apache.org/jira/browse/CRUNCH-400
> Project: Crunch
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.9.0, 0.8.2
> Reporter: Micah Whitacre
> Attachments: CRUNCH-400.patch
>
>
> Brought up as part of the proposed fix for CRUNCH-272 and on the mailing
> list[1], a set of jobs kicked off due to a materialize() call will not be
> tracked as part of the Pipeline's stage results returned by the
> PipelineResult.
> [1] -
> http://mail-archives.apache.org/mod_mbox/crunch-dev/201405.mbox/%3CCANFazTUAffvTctK5%3DWvW4KyBLSqLCNcke7ZMWwgASu%2BEtkDmyQ%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.2#6252)
