[
https://issues.apache.org/jira/browse/CRUNCH-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064986#comment-14064986
]
John Leacox commented on CRUNCH-357:
------------------------------------
This change contains a non-passive change of the AvroMode.override return type
from 'void' to 'AvroMode'. Was this intended? I was going to log a bug, but
switching it back to 'void' would now also be a non-passive change.
This is preventing us from upgrading our crunch version until all of our
dependencies that use this method have also upgraded.
{code}
- public void override(ReaderWriterFactory factory) {
+ public AvroMode override(ReaderWriterFactory factory) {
{code}
> Allow AvroMode overrides to be less global
> ------------------------------------------
>
> Key: CRUNCH-357
> URL: https://issues.apache.org/jira/browse/CRUNCH-357
> Project: Crunch
> Issue Type: Improvement
> Components: Core, IO
> Reporter: Micah Whitacre
> Assignee: Micah Whitacre
> Fix For: 0.10.0, 0.8.3
>
> Attachments: CRUNCH-357.patch, CRUNCH-357_immutable.patch,
> CRUNCH-357_immutable_with_doctests.patch
>
>
> Currently consumers wanting to specify a custom reader must globally override
> the ReaderFactory for a specific mode. This means that if one AvroFileSource
> changes the factory it could affect all other sources in the pipeline without
> anyone knowing it.
> One thought was what if a consumer could get a "local" AvroMode instance,
> configure it to their needs and then specify that mode to the AvroFileSource
> to configure that source without changing any global state.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
