[
https://issues.apache.org/jira/browse/CRUNCH-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065012#comment-14065012
]
Josh Wills commented on CRUNCH-446:
-----------------------------------
New patch looks good, although I had some trouble running it: a few unit tests
failed b/c of DoFn initialization (easily fixed), but then a ton of integration
tests failed for seemingly unrelated reasons, like heap space exceptions. I
verified that everything in master works; any inkling of what's going on?
> Add null checks for DoFn fields
> -------------------------------
>
> Key: CRUNCH-446
> URL: https://issues.apache.org/jira/browse/CRUNCH-446
> Project: Crunch
> Issue Type: Improvement
> Reporter: Allan Shoup
> Priority: Minor
> Attachments: CRUNCH-446.2.patch, CRUNCH-446.patch
>
>
> DoFn.getConfiguration() gracefully handles the fields being null, but most
> other methods do not. Adding null checks around all field access within DoFn
> would make it easier for consumers to write tests for their own function
> classes because they would not be required to set the context, for instance.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
