[
https://issues.apache.org/jira/browse/CRUNCH-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabriel Reid resolved CRUNCH-567.
---------------------------------
Resolution: Fixed
Assignee: Gabriel Reid (was: Josh Wills)
Fix Version/s: 0.14.0
Committed to master.
Thanks for the patch [~srowen] (and BTW, yes we're still generally working with
patches here).
> close() triggers NPE if initialize() fails in 2 classes
> -------------------------------------------------------
>
> Key: CRUNCH-567
> URL: https://issues.apache.org/jira/browse/CRUNCH-567
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.12.0
> Reporter: Sean Owen
> Assignee: Gabriel Reid
> Priority: Trivial
> Fix For: 0.14.0
>
> Attachments: CRUNCH-567.patch
>
>
> Quite trivial, but just noticed this on a customer project: in
> AvroRecordReader and HFileInputFormat, close() closes a reader object.
> However it will be null if initialize() is never called or fails to complete
> normally, generating an NPE. It ends up being an issue since their close() is
> called in some kind of finally block at some point.
> Attaching a patch for now but do we do pull requests here now instead?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
