[ 
https://issues.apache.org/jira/browse/CRUNCH-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205197#comment-15205197
 ] 

Piotr Chromiec commented on CRUNCH-596:
---------------------------------------

You're quick! :) Thanks.

I was not sure about this IdentityFn change. Can you explain little bit why do 
you prefer not to loose access to constructor?

I closed PR on GitHub
https://github.com/apache/crunch/pull/9

> Right and full outer join for Bloom filter strategy
> ---------------------------------------------------
>
>                 Key: CRUNCH-596
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-596
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.13.0
>            Reporter: Piotr Chromiec
>            Assignee: Gabriel Reid
>            Priority: Minor
>              Labels: features, github-import, newbie
>             Fix For: 0.14.0
>
>
> Seems that current Bloom filter join strategy lacks of support for right and 
> full outer joins. At RTBHOUSE we had recently found this as useful and 
> implemented for our internal project. Code for this feature with javadoc and 
> tests is pushed at GitHub 
> [PullRequest#9|https://github.com/apache/crunch/pull/9]
> I'm newbie here so forgive me if this issue is somehow incomplete or buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to