[
https://issues.apache.org/jira/browse/CRUNCH-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929339#comment-15929339
]
Stephen Patel commented on CRUNCH-639:
--------------------------------------
Ahhh. I see. It hasn't bitten us because we always know that the byte buffers
are backed by arrays and are whole and unsliced, but naturally that may not be
true in the general case. Thanks for the link Micah. I'm cool with closing
this jira.
> Writable Bytes does an unnecessary copy
> ---------------------------------------
>
> Key: CRUNCH-639
> URL: https://issues.apache.org/jira/browse/CRUNCH-639
> Project: Crunch
> Issue Type: Improvement
> Components: Core
> Reporter: Stephen Patel
> Assignee: Josh Wills
> Priority: Minor
>
> In the Writable.bytes() Output MapFn, an unnecessary (I believe) copy of the
> incoming ByteBuffer occurs[0].
> Current:
> {code}
> BytesWritable bw = new BytesWritable();
> bw.set(input.array(), input.arrayOffset(), input.limit()); <- copies the array
> {code}
> Proposed:
> {code}
> BytesWritable bw = new BytesWritable(input.array());
> {code}
> [0]:
> https://github.com/apache/crunch/blob/apache-crunch-0.15.0/crunch-core/src/main/java/org/apache/crunch/types/writable/Writables.java#L271
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
