[
https://issues.apache.org/jira/browse/CRUNCH-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965920#comment-15965920
]
Tom White commented on CRUNCH-641:
----------------------------------
+1. Pushed to master. Thanks Gergő!
> Wrong decimal format in dot files
> ---------------------------------
>
> Key: CRUNCH-641
> URL: https://issues.apache.org/jira/browse/CRUNCH-641
> Project: Crunch
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.15.0, 1.0.0
> Reporter: Gergő Pásztor
> Assignee: Gergő Pásztor
> Priority: Minor
> Attachments: CRUNCH-641_v1.patch
>
>
> Failed tests:
> testFormatPCollectionNodeDeclaration(org.apache.crunch.impl.mr.plan.DotfileWriterTest):
> expected:<...[label="collection 0[.]49 Mb" shape=box];> but
> was:<...[label="collection 0[,]49 Mb" shape=box];>
>
> testFormatPCollectionNodeDeclaration_InputPCollection(org.apache.crunch.impl.mr.plan.DotfileWriterTest):
> expected:<...rce" [label="input 1[,]729 Mb" shape=folder...> but
> was:<...rce" [label="input 1[ ]729 Mb" shape=folder...>
>
> testFormatPGroupedTableImplDeclarationAutomatic(org.apache.crunch.impl.mr.plan.DotfileWriterTest):
> expected:<...35802" [label="GBK 1[,]729 Mb (10 Automatic...> but
> was:<...35802" [label="GBK 1[ ]729 Mb (10 Automatic...>
>
> testFormatPGroupedTableImplDeclarationManual(org.apache.crunch.impl.mr.plan.DotfileWriterTest):
> expected:<...[label="collection 1[,]729 Mb (50 Manual re...> but
> was:<...[label="collection 1[ ]729 Mb (50 Manual re...>
> Java is using the computer's settings to setup the locale and after using
> this settings to format a number in the dot files. It's not a big problem,
> because probably only has effect on developers machines, but we should fix it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
