[ 
https://issues.apache.org/jira/browse/CRUNCH-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021422#comment-16021422
 ] 

Attila Sasvari commented on CRUNCH-619:
---------------------------------------

[~pairg] thanks for the updated patch. 

I started to look at hbase2_v5 patch, some comments:
* Unit tests passed. Also ran SparkHFileTargetIT and SparkWordCountHBaseIT, and 
they passed.
* In HFileTargetIT.java and SparkHFileTargetIT.java we should not use wildcard 
import such as {{import org.apache.hadoop.hbase.*;}}


> Run on HBase 2
> --------------
>
>                 Key: CRUNCH-619
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-619
>             Project: Crunch
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Tom White
>            Assignee: Gergő Pásztor
>             Fix For: 1.0.0
>
>         Attachments: CRUNCH-619-2.patch, CRUNCH-619.patch, 
> CRUNCH-619_v3.patch, CRUNCH-619_v4_hbase1.patch, CRUNCH-619_v4_hbase2.patch, 
> CRUNCH-619_v5_hbase2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to