Hi,
I have reported and provided patch for:
https://issues.apache.org/jira/browse/CTAKES-456
I hope it helps to improve readability at least.
Is there anything else related to the process of providing patches?
Regards,
Alexz
diff --git ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/UMLSFeatureExtractor.java ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/UMLSFeatureExtractor.java
index 3a95796d..bcca63ac 100644
--- ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/UMLSFeatureExtractor.java
+++ ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/UMLSFeatureExtractor.java
@@ -78,7 +78,7 @@ public class UMLSFeatureExtractor implements RelationFeaturesExtractor<Identifie
feats.add(new Feature("Arg1Arg2BothCui", true));
}
- if((ents1.size() == 0 & ents2.size() > 0) ||
+ if((ents1.size() == 0 && ents2.size() > 0) ||
(ents1.size() > 0 && ents2.size() == 0)){
feats.add(new Feature("Arg1OrArg2NoCui", true));
}
diff --git ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/cluster/MentionClusterUMLSFeatureExtractor.java ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/cluster/MentionClusterUMLSFeatureExtractor.java
index 319daaf0..9e595c73 100644
--- ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/cluster/MentionClusterUMLSFeatureExtractor.java
+++ ctakes-coreference/src/main/java/org/apache/ctakes/coreference/ae/features/cluster/MentionClusterUMLSFeatureExtractor.java
@@ -89,7 +89,7 @@ public class MentionClusterUMLSFeatureExtractor implements
trueFeats.add("ClusterMentionBothCui");
}
- if((clusterEnts.size() == 0 & mentionEnts.size() > 0) ||
+ if((clusterEnts.size() == 0 && mentionEnts.size() > 0) ||
(clusterEnts.size() > 0 && mentionEnts.size() == 0)){
trueFeats.add("ClusterOrMentionNoCui");
}