Hi Sean, Thank you for your feedback. I will go and commit then.
I documented the execution of UMLS UTests on the Developer Install Guide [1] and yes, you're right, the priority would be to update and improve existing UTests and also to create new ones to catch up with code-coverage. As part of this work, I will try to fix the issues around the release process process, too. Alex [1] - https://cwiki.apache.org/confluence/display/CTAKES/ cTAKES+4.0+Developer+Install+Guide On Thu, Nov 16, 2017 at 10:43 AM, Finan, Sean < [email protected]> wrote: > Hi Alex, my responses are below. > > >I think is even more convenient than using the apache-release profile. > The rule of thumb would be that apache-release profile is used only by the > person assigned by ?the PMC to do the releases > -- Ok, fair enough > > >. Yes, the apache-release profile is working for me. > -- If you are comfortable with it ... go ahead and commit. So far there > has been no negative feedback on your idea. > > > UMLS tests are executed if you use the environment variables for UMLS > credentials, no extra profile is needed now. > -- understood. They just aren't forced except for the release. My only > thought was just another profile with a different name for regression (that > forces umls*). > > >But of course, if you find it more convenient to have an extra profile, I > can create one, no problem. > -- Not more convenient. Don't worry about it. > > >Writing these here, I realize that a development documentation on the > wiki would be helpful. Any advice if/where I should create the page? > -- Maybe a sibling of the dev install ? "Developer Test Guide?" > https://cwiki.apache.org/confluence/display/CTAKES/ > cTAKES+4.0+Developer+Install+Guide > > >I will also add Categories to these tests, which indeed is a great idea. > I propose it to be as a next commit though. > -- Definitely no rush, and not required. Much more important would be > adding new and updating/improving existing unit tests ... > > > This creates a new discussion about a bug in our pom that disables the > apache parent enforcement to use the apache-release profile for release > builds and also to skip tests. > -- yes, that is a problem ... skipping tests on a release build is a bad > idea. > > > I would like to address it in a further commit. I would like the consent > from the person responsible for releases to do this, though. > -- We don't have an rm for ctakes. Everything ctakes is purely voluntary, > and a release can be put together at pretty much any time as long as there > is effort behind it. > > Sean >
