Hi Peter,
Of course you did the right thing! As far as I am concerned.
You are one of the official committers - membership has its privileges or
something along those lines.
Sean
________________________________________
From: Peter Abramowitsch <pabramowit...@gmail.com>
Sent: Tuesday, December 8, 2020 4:20 PM
To: dev@ctakes.apache.org
Subject: Re: 4.0.0 trial UserTester [EXTERNAL] [SUSPICIOUS]
* External Email - Caution *
Hi Sean
Hope I did the right thing,
I felt better creating the tester file to fit the configuration rather than
change the configuration. And since the other tester didn't do much - it
was just a stub......
Peter
On Tue, Dec 8, 2020 at 9:33 PM Peter Abramowitsch <pabramowit...@gmail.com>
wrote:
> exactement.
>
> On Tue, Dec 8, 2020 at 8:02 PM Finan, Sean <
> sean.fi...@childrens.harvard.edu> wrote:
>
>> Argh. And now I notice that there is no /*Tester.java ...
>> ________________________________________
>> From: Finan, Sean <sean.fi...@childrens.harvard.edu>
>> Sent: Tuesday, December 8, 2020 1:56 PM
>> To: dev@ctakes.apache.org
>> Subject: Re: 4.0.0 trial UserTester [EXTERNAL] [SUSPICIOUS]
>>
>> * External Email - Caution *
>>
>>
>> Peter, thanks for making the test(s) actually do something.
>>
>> Just as an aside, since it doesn't much matter right now, but supposedly
>> <plugin>
>>
>> <artifactId>maven-surefire-plugin</artifactId>
>>
>> <version>${maven-surefire-plugin.version}</version>
>> <configuration>
>> <includes>
>>
>> <include>**/Test*.java</include>
>>
>> <include>**/*Test.java</include>
>>
>> <include>**/*Tests.java</include>
>>
>> <include>**/*TestCase.java</include>
>> </includes>
>> Removes that junit class naming requirement when testing with maven.
>>
>> In junit 5 "Test*" was added to the default test class search for running
>> junit by other means.
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_junit-2Dteam_junit5_commit_ce303c347e42b606ce51eaf72294dabf19a0ae72&d=DwIFAw&c=qS4goWBT7poplM69zy_3xhKwEW14JZMSdioCoppxeFU&r=fs67GvlGZstTpyIisCYNYmQCP6r0bcpKGd4f7d4gTao&m=9YvriB5zsxbV_Gibqia-BK7YsSb52NseyKFHZKgkdD0&s=y7UBsvsxgj8m2K9hxqT2nUKmHBCJJCQJU0os--y5rY4&e=
>>
>> junit 5. Yet another ctakes update that would be nice to have.
>>
>> Sean
>>
>> ________________________________________
>> From: Peter Abramowitsch <pabramowit...@gmail.com>
>> Sent: Tuesday, December 8, 2020 1:03 PM
>> To: dev@ctakes.apache.org
>> Subject: 4.0.0 trial UserTester [EXTERNAL]
>>
>> * External Email - Caution *
>>
>>
>> Tim - yes the UmlsUserTester.java was old code and needs to go. It never
>> did anything and didn't have a name recognized by Junit. I created a new
>> one side by side called UmlsUserTest.java It does work but is disabled
>> because you need to modify it and your environment to perform all the
>> tests
>> it does. Requirements for testing are documented in the code.
>>
>> Peter
>>
>
