Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/6#discussion_r12513097
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -72,6 +74,9 @@
private final NamespaceWatcherMap
namespaceWatcherMap = new NamespaceWatcherMap(this);
private volatile ExecutorService
executorService;
+ private final AtomicBoolean
logAsErrorConnectionErrors = new AtomicBoolean(false);
+
+ private static final boolean
LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL =
Boolean.getBoolean(DebugUtils.PROPERTY_LOG_ALL_CONNECTION_ISSUES_AS_ERROR_LEVEL);
--- End diff --
This is fine, but I think the default should be TRUE so that we retain the
previous behavior. People who want the new behavior can set the property. What
do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
