[ https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074128#comment-14074128 ]
ASF GitHub Bot commented on CURATOR-33: --------------------------------------- Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/17#issuecomment-50111927 Overall, looks really good. I've made a few minor comments. My only other comment would be that it would be nice to see some more unit tests specific to a multi level cache. It's good that the TreeCache works against all of the PathChildrenCache tests, but I could only see 1 test that specifically deals with data with a depth > 2. > Recursive Node Cache > -------------------- > > Key: CURATOR-33 > URL: https://issues.apache.org/jira/browse/CURATOR-33 > Project: Apache Curator > Issue Type: Improvement > Components: Recipes > Reporter: John Vines > Fix For: awaiting-response > > Attachments: CURATOR-33.2.patch, CURATOR-33.patch > > > Currently the PathChildrenCache will trigger listen events for all children > at the given node. However, it would be useful to have a cache that would > trigger listen events for the entire hierarchy below the given node. -- This message was sent by Atlassian JIRA (v6.2#6252)