[
https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077164#comment-14077164
]
ASF GitHub Bot commented on CURATOR-126:
----------------------------------------
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/23#issuecomment-50418758
I pushed an update to the test that has an assert. I tested it with the old
background thread code and the test fails. It succeeds with the new code.
-JZ
From: cammckenzie <notificati...@github.com>
Reply: apache/curator <re...@reply.github.com>>
Date: July 28, 2014 at 6:29:46 PM
To: apache/curator <cura...@noreply.github.com>>
Cc: Jordan Zimmerman <jor...@jordanzimmerman.com>>
Subject: Re: [curator] CURATOR-126: Fix race condition in
CuratorFrameworkImpl.close() (#23)
I have pushed a unit test up onto the CURATOR-126 branch. Have a play with
it, I still seem to be getting the error logged when running against the fix.
Could be something bogus in the test though.
—
Reply to this email directly or view it on GitHub.
> IllegalStateException in performBackgroundOperation during close
> ----------------------------------------------------------------
>
> Key: CURATOR-126
> URL: https://issues.apache.org/jira/browse/CURATOR-126
> Project: Apache Curator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 2.5.0
> Reporter: Scott Blum
> Assignee: Jordan Zimmerman
> Fix For: 2.7.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> {code}
> [CuratorFramework-0] ERROR
> org.apache.curator.framework.imps.CuratorFrameworkImpl - Background
> exception was not retry-able or retry gave up
> java.lang.IllegalStateException: Client is not started
> at
> com.google.common.base.Preconditions.checkState(Preconditions.java:176)
> at
> org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.performBackgroundOperation(CuratorFrameworkImpl.java:807)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.backgroundOperationsLoop(CuratorFrameworkImpl.java:793)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl.access$400(CuratorFrameworkImpl.java:57)
> at
> org.apache.curator.framework.imps.CuratorFrameworkImpl$4.call(CuratorFrameworkImpl.java:275)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:744)
> {code}
> I see this sometimes during test runs; I believe this happens because
> CuratorZookeeperClient.started gets set to false during shutdown, but the
> backgroundOperation loop can still be running since shutting down the
> backgroundOperation loop is inherently racy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
