[
https://issues.apache.org/jira/browse/CURATOR-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081639#comment-14081639
]
ASF GitHub Bot commented on CURATOR-33:
---------------------------------------
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/17#discussion_r15675387
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCacheEvent.java
---
@@ -0,0 +1,126 @@
+/**
--- End diff --
Glad you brought this up; it's a straight copy, I think the only changes
are renaming things like CHILD_ADDED -> NODE_ADDED. I tried to consistently
switch to "node" terminology since nodes in the tree cache can be both parents
and children (as opposed to PathChildrenCache). Also, I wasn't sure how weird
it would be to have a TreeCache emitting PathChildrenCacheEvents.
I do kind of like the idea of deprecating the old event interfaces and
creating a new one that can consistently surface events for all 3 caches.
Perhaps we could call it "CacheEvent" and it would essentially look like
TreeCacheEvent. I think NodeCache would be especially improved by this, since
at the moment all it offers is a "nodeChanged" event.
The caches could simply keep two lists of listeners and publish both new
and old style events.
What do you think?
> Recursive Node Cache
> --------------------
>
> Key: CURATOR-33
> URL: https://issues.apache.org/jira/browse/CURATOR-33
> Project: Apache Curator
> Issue Type: Improvement
> Components: Recipes
> Reporter: John Vines
> Assignee: Jordan Zimmerman
> Fix For: TBD
>
> Attachments: CURATOR-33.2.patch, CURATOR-33.patch
>
>
> Currently the PathChildrenCache will trigger listen events for all children
> at the given node. However, it would be useful to have a cache that would
> trigger listen events for the entire hierarchy below the given node.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
