[ https://issues.apache.org/jira/browse/CURATOR-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157075#comment-14157075 ]
Scott Blum commented on CURATOR-151: ------------------------------------ Yeah, I considered that, but have a mild preference for passing in the previous versioned value, for two reasons: 1) The API becomes crystal clear as far as what you must pass in-- a value previously returned from a reason. 2) Specifically for SharedCount, you avoid the potential for argument order mixup with (int, int) and conflating version with value. Mild preference though, if you have a strong pref for the second formulation we could do it that way. > SharedValue has limited utility but can be improved > --------------------------------------------------- > > Key: CURATOR-151 > URL: https://issues.apache.org/jira/browse/CURATOR-151 > Project: Apache Curator > Issue Type: Improvement > Components: Recipes > Affects Versions: 2.6.0 > Reporter: Jordan Zimmerman > Assignee: Jordan Zimmerman > Fix For: 2.7.0 > > > Currently, SharedValue has limited utility as the internally managed version > is always used for trySetValue. A good improvement would be a) add an API to > get the current value AND current version and b) add an alternate trySetValue > that takes a new value AND an expected version. -- This message was sent by Atlassian JIRA (v6.3.4#6332)