[
https://issues.apache.org/jira/browse/CURATOR-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540273#comment-14540273
]
ASF GitHub Bot commented on CURATOR-219:
----------------------------------------
GitHub user madrob opened a pull request:
https://github.com/apache/curator/pull/78
CURATOR-219 Catch Exceptions, not Throwables
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madrob/curator CURATOR-219
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 865b4a6bbac6e486f85bc725cb15a69efdfd0521
Author: Mike Drob <md...@cloudera.com>
Date: 2015-05-12T17:18:19Z
CURATOR-219 Catch Exceptions, not Throwables
----
> Avoid use of Throwable
> ----------------------
>
> Key: CURATOR-219
> URL: https://issues.apache.org/jira/browse/CURATOR-219
> Project: Apache Curator
> Issue Type: Bug
> Reporter: Mike Drob
> Assignee: Jordan Zimmerman
> Fix For: 3.0.0
>
>
> We liberally catch {{Throwable}} in our code, which can mask more troubling
> issues like {{OutOfMemory}} or other errors. In most cases we should be
> catching Exception instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
