[ 
https://issues.apache.org/jira/browse/CURATOR-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662282#comment-14662282
 ] 

Mike Drob commented on CURATOR-129:
-----------------------------------

I just pushed this change. Can somebody look and verify that I handled things 
the way that we're used to?

Created a branch, pushed it to the git repository with the fix. Merged it into 
master, added a line about closing the pull request to the commit message, and 
then pushed that. Looks like it ended up being a fast-forward instead of giving 
me a merge commit. Do we have a preference on that? I couldn't find anything on 
the wiki pages indicating one way or the other.

> Two of PathChildrenCache's constructors need better doc
> -------------------------------------------------------
>
>                 Key: CURATOR-129
>                 URL: https://issues.apache.org/jira/browse/CURATOR-129
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Documentation, Recipes
>    Affects Versions: 2.6.0
>            Reporter: Jordan Zimmerman
>
> The two constructors for PathChildrenCache that take executors as arguments 
> need to document that the executors must be single threaded. If a pool 
> executor is passed in, PathChildrenCache will not work correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to