[
https://issues.apache.org/jira/browse/CURATOR-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720389#comment-14720389
]
ASF GitHub Bot commented on CURATOR-253:
----------------------------------------
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/100#discussion_r38231122
--- Diff:
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentEphemeralNode.java
---
@@ -634,11 +640,6 @@ private CuratorFramework newCurator() throws
IOException
return client;
}
- public void killSession(CuratorFramework curator) throws Exception
- {
- KillSession.kill(curator.getZookeeperClient().getZooKeeper(),
curator.getZookeeperClient().getCurrentConnectionString());
--- End diff --
Why not leave the method and have it do the new thing instead of repeating
the same snippet in a bunch of places?
> Use new injectSessionExpiration() in the test module
> ----------------------------------------------------
>
> Key: CURATOR-253
> URL: https://issues.apache.org/jira/browse/CURATOR-253
> Project: Apache Curator
> Issue Type: Sub-task
> Components: Tests
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.0.0
>
>
> ZK 3.5.0 adds the Testable interface and the injectSessionExpiration()
> method. Curator's KillSession utils should use this instead of what's
> currently done.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
