Github user lvfangmin commented on the issue:

    https://github.com/apache/curator/pull/208
  
    One concern is that this diff changed the default behavior to not passing 
'enable', which will break the users who are already using service discovery 
server and client with the enable field.
    
    If I understand correctly, there are 4 cases:
    
    1. discovery server: w enable,     client: w enable
    2. discovery server: w/o enable, client: w/o enable
    3. discovery server: w/o enable, client: w enable
    4. discovery server: w enable,    client: w/o enable
    
    
    The first 2 cases we don't need to worry about, the 3rd one will fail 
because the server cannot recognize the new enable field, the 4th will fail 
because the client cannot recognize the new field, sounds like we only need to 
change the code to be able to ignore unknown field, what's the reason of having 
OldServiceInstance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to