Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/curator/pull/205#discussion_r127384585
--- Diff:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestReconfiguration.java
---
@@ -313,6 +313,38 @@ public void testNewMembers() throws Exception
}
}
+ @Test
+ public void testConfigToConnectionStringNormal() throws Exception
+ {
+ String config =
"server.1=10.1.2.3:2888:3888:participant;10.2.3.4:2181";
+ String configString =
EnsembleTracker.configToConnectionString(toQuorumVerifier(config.getBytes()));
+ Assert.assertEquals("10.2.3.4:2181", configString);
+ }
+
+ @Test
+ public void testConfigToConnectionStringNoClientAddr() throws Exception
+ {
+ String config = "server.1=10.1.2.3:2888:3888:participant;2181";
+ String configString =
EnsembleTracker.configToConnectionString(toQuorumVerifier(config.getBytes()));
+ Assert.assertEquals("10.1.2.3:2181", configString);
+ }
+
+ @Test
+ public void testConfigToConnectionStringWildcardClientAddr() throws
Exception
+ {
+ String config =
"server.1=10.1.2.3:2888:3888:participant;0.0.0.0:2181";
--- End diff --
Please also add a test case for IPv6 wildcard:
server.1=[1010:0001:0002:0003:0004:0005:0006:0007]:2888:3888:participant;[::0]:2181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
