Github user madrob commented on a diff in the pull request:

    https://github.com/apache/curator/pull/242#discussion_r153252423
  
    --- Diff: 
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
 ---
    @@ -640,12 +646,14 @@ boolean useContainerParentsIfAvailable()
             }
         }
     
    -    <DATA_TYPE> void queueOperation(OperationAndData<DATA_TYPE> 
operationAndData)
    +    <DATA_TYPE> boolean queueOperation(OperationAndData<DATA_TYPE> 
operationAndData)
    --- End diff --
    
    Please add a comment explaining how to handle the return value -- there are 
a lot of callers that have not been updated to check the new return value. 
Looks like true iff the operation was queued?


---

Reply via email to