Github user njhill commented on a diff in the pull request:
https://github.com/apache/curator/pull/250#discussion_r167715541
--- Diff:
curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java
---
@@ -704,8 +687,7 @@ private TreeNode find(String findPath)
{
TreeNode childNode = entry.getValue();
ChildData childData = childNode.childData;
- // Double-check liveness after retreiving data.
--- End diff --
The reason I removed it is that unlike before it's not really "double"
checking anymore against the separate `nodeState` field, there's only a single
check for liveness which is now implicit in the value of `childData`. But I
could well have misinterpreted the reason for comment, no problem with leaving
it in!
---
