Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179651175 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -340,4 +338,12 @@ private void setCurrentConnectionState(ConnectionState newConnectionState) currentConnectionState = newConnectionState; startOfSuspendedEpoch = (currentConnectionState == ConnectionState.SUSPENDED) ? System.currentTimeMillis() : 0; } + + private synchronized int getUseSessionTimeoutMs() { --- End diff -- Looks like the comment on `startOfSuspendedEpoch` "guarded by sync" is a lie. `getUseSessionTimeoutMs()` doesn't need to be synchronized if we make `startOfSuspendedEpoch` volatile.
---