Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/266#discussion_r194463547
  
    --- Diff: 
curator-client/src/main/java/org/apache/curator/CuratorZookeeperClient.java ---
    @@ -213,18 +213,25 @@ public void start() throws Exception
     
             state.start();
         }
    -
    +    
    +    /**
    +     * Close the client
    +     */
    +    public void close() {
    +        close(0);
    +    }
    +            
         /**
          * Close the client
          */
    -    public void close()
    +    public void close(int timeout)
    --- End diff --
    
    Missing Javadoc for param `timeout` (also should be `timeoutMs`)


---

Reply via email to